-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
glibc: 2.33-108 -> 2.34-115 #133431
glibc: 2.33-108 -> 2.34-115 #133431
Conversation
@vcunat @lovesegfault I can build on this branch
Thanks! :) |
Does this require the binutils update? |
Doesn't seem as if that's the case currently :) |
I'm not sure if it's good to test them separately and then merge without testing those two updates together. |
Quick look: the bootstrapping change is OK-ish, I think. The rest seems good. I'm not sure why diffutils update was included. Nit: |
I haven't taken a close look at bintuils, but considering that I even had to do some workarounds to get gcc building (yay, compatibility), I guess this will take a while (no idea if it'll land in 21.11), so it's rather likely that this will be here for a while after a
OK, great! :)
With this change, the package compiled again (but good point, should perhaps add a note to the commit message).
Oh, good point :) |
3b991bb
to
f1d5672
Compare
I cancelled these builds for now, as too much work is piling up. (also PR #135611) |
@vcunat Hydra's queue status currently says |
Yes, most of 21.05 jobs still don't have binaries with the new openssl. And then there's lots of stuff that was cancelled and will also want to continue after this settles, e.g. the current |
fetchpatchable patch for catch 1.x: https://src.fedoraproject.org/rpms/catch1/blob/059104ba87494c0b5ebe16844ec190f253e51cac/f/catch1-sigstksz.patch |
This reverts commit 4427e54. Patch is not needed anymore.
Sorry I just say this now. Restarted |
TIL to build my entire workstation's NixOS from source, I need a c6a.32xlarge from AWS and ~90GB of free disk space. In other words, I'm currently writing this comment from a NixOS using glibc 2.34. Since that's also working perfectly fine, I'd say that this PR has reached a reasonably stable state. @jonringer I guess it'd make sense to cancel the jobset again and start a new eval with the current state. As soon as everything else is sorted out, I'd be fine with merging :) |
No idea why this breaks now, but let's see if that's sufficient to make ofborg happy.
I think we can get the remaining regressions in staging-next. The next round should probably be dedicated to glibc, then the round after for systemd 250. |
cc @NixOS/nixos-release-managers |
So the recent hydra.nixos.org evaluation of this should be cancelled? I can't see why it's building on both farms at once. |
I think that was on oversight of mine, cancelled on hydra.nixos.org, sorry! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Result of nixpkgs-review pr 133431 run on x86_64-linux 1
2 packages built:
- python3Packages.numpy
- ripgrep
I think |
fyi the stdenv is still building fine for me, ut I guess that there's another GCC to be built, so this should be merged, but it's not a blocker. |
also, does that mean you're working on glibc-2.35? :) (in that case the next mass-rebuild project for me would be a GCC major bump %)) |
I run |
Motivation for this change
Announcement: https://sourceware.org/pipermail/libc-alpha/2021-August/129718.html
Hydra jobset: https://hydra.nixos.org/jobset/nixpkgs/glibc-2.34
Note for reviewers: this update is slightly more nasty than the previous ones, especially the following commits should be reviewed closely:
glibc: 2.33-108 -> 2.34-115
)nixos/stage-1: fix modprobe in initial ramdisk on systems w/glibc-2.34
)glibc: don't hide symbol __nss_files_fopen
Todos:
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)